search

containers / containrs

General purpose container library
Apache License 2.0
121 stars 21 forks source link

Make unix domain socket work with crictl #34

Open saschagrunert opened 4 years ago

saschagrunert commented 4 years ago

Looks like we're facing those issues with the default implementation as well:

I was able to connect via grpccurl, which does not have to seem the issue when specifying the socket:

> sudo ./grpcurl -plaintext -unix -protoset cri.protoset cri.sock criapi.RuntimeService.Version
saschagrunert commented 4 years ago

Looks like the issue got solved with https://github.com/grpc/grpc-go/pull/3730

saschagrunert commented 4 years ago

Trying to solve the other issue in h2: https://github.com/hyperium/h2/pull/487

saschagrunert commented 4 years ago

The latest master of tonic would be required too, but I guess we can wait for the next release.

Ref: https://github.com/hyperium/tonic/issues/443

Ruilkyu commented 3 years ago

Has 0.4.0 solved the problem?