containers / crun

A fast and lightweight fully featured OCI runtime and C library for running containers
GNU General Public License v2.0
2.87k stars 294 forks source link

tests, oci-tests: update npm #1455

Closed giuseppe closed 2 months ago

giuseppe commented 2 months ago

let's wait for (oci-validation) to pass before merging

flouthoc commented 2 months ago

Test fails with

+ export GO111MODULE=off
+ GO111MODULE=off
+ go get -d -u github.com/opencontainers/runtime-tools
go: modules disabled by GO111MODULE=off; see 'go help modules'
+ true
+ export GOCACHE=/var/tmp/gocache
+ GOCACHE=/var/tmp/gocache
+ export TMPDIR=/var/tmp
+ TMPDIR=/var/tmp
+ export XDG_RUNTIME_DIR=/run
+ XDG_RUNTIME_DIR=/run
+ cd /root/go/src/github.com/opencontainers/runtime-tools
/usr/local/bin/run-tests.sh: line 29: cd: /root/go/src/github.com/opencontainers/runtime-tools: No such file or directory

Not sure but I think the line go get -d -u github.com/opencontainers/runtime-tools || true did not download and install the go mod correctly.

giuseppe commented 2 months ago

tests are green now

rhatdan commented 2 months ago

LGTM