containers / crun

A fast and lightweight fully featured OCI runtime and C library for running containers
GNU General Public License v2.0
2.87k stars 294 forks source link

Fixes for RPM, Packit and TMT #1470

Closed lsm5 closed 1 month ago

lsm5 commented 1 month ago

This set of commits fixes the epoch value on the podman-next copr. It also moves all downstream gating test maintenance to upstream.

TMT tests end up calling make targets so the tests are usable even without any TMT setup.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

cgwalters commented 1 month ago

FWIW the artifact task from this PR is hanging forever apparently, and is taking up 6 out of 20 runners in this github organization.

cgwalters commented 1 month ago

Please rebase on https://github.com/containers/crun/pull/1472

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {1: {'packages': defaultdict(<class 'dict'>, {'crun-centos': {'value': {'targets': ["Expected <class 'list'>, got 'epel-release' (type <class 'str'>)"]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 1 month ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {1: {'packages': defaultdict(<class 'dict'>, {'crun-centos': {'value': {'targets': ["Expected <class 'list'>, got 'epel-release' (type <class 'str'>)"]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 1 month ago

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {1: {'packages': defaultdict(<class 'dict'>, {'crun-centos': {'value': {'targets': ["Expected <class 'list'>, got 'epel-release' (type <class 'str'>)"]}}})}}})

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

packit-as-a-service[bot] commented 1 month ago

podman system tests failed. @containers/packit-build please check.

lsm5 commented 1 month ago

@giuseppe @edsantiago PTAL

I've not enabled RHEL10 yet, only CentOS Stream 10 for now. RHEL-10 gives me conflicts between the redhat-release and containers-common package installed from podman-next Copr on the RPM-GPG-KEY-redhat-release file.

Also, i'm installing bats from source on CentOS Stream 10 until epel 10 becomes available because installing from epel9 on centos stream 10 causes other issues.

giuseppe commented 1 month ago

LGTM, could you only take care of this issue reported by make syntax-check:

plans/all.fmf
maint.mk: empty line(s) or no newline at EOF

If it is not possible to fix, then we need to ignore these files by tweaking VC_LIST_EXCEPT_DEFAULT in the cfg.mk file

lsm5 commented 1 month ago

LGTM, could you only take care of this issue reported by make syntax-check:

plans/all.fmf
maint.mk: empty line(s) or no newline at EOF

Done. Thanks!

lsm5 commented 1 month ago

i'll fix shellcheck stuff too. setting to draft.

lsm5 commented 1 month ago

ready for review