Do not error on del command

containers / dnsname

name resolution for containers

Apache License 2.0

177 stars 47 forks source link

Do not error on del command #73

Closed Luap99 closed 3 years ago

Luap99 commented 3 years ago

According to the cni spec[1], a plugin should not return an error on del. If a plugin returns an error cni will not call the following plugins. Since the plugins are invoked in reverse order on del, the portmapping and bridge plugins won't get invoked and therefore leave iptables rules around.

Fixes #67 Fixes containers/podman#10806 Fixes containers/podman#10745

[1] https://github.com/containernetworking/cni/blob/master/SPEC.md#del-remove-container-from-network-or-un-apply-modifications

rhatdan commented 3 years ago

LGTM @baude @mheon @edsantiago PTAL

mheon commented 3 years ago

/lgtm

mheon commented 3 years ago

/approve

baude commented 3 years ago

/approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/dnsname/blob/main/OWNERS)~~ [baude,mheon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

edsantiago commented 3 years ago

Belated LGTM. Thank you @Luap99