search

containers / dnsname

name resolution for containers
Apache License 2.0
177 stars 47 forks source link

Fix build and install instructions #94

Closed ivandov closed 1 year ago

ivandov commented 2 years ago

Instructions did not supply the command to build the binary (make) and therefore the make install would fail because the bin directory did not exist.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivandov To complete the pull request process, please assign rhatdan after the PR has been reviewed. You can assign the PR to them by writing /assign @rhatdan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/containers/dnsname/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 2 years ago

You need to sign your commit message.

git commit -a --amend -s git push --force

ivandov commented 2 years ago

Signed the commit, and also realized this is almost identical to PR #93 which address issue #91.

Not sure if this PR should be closed since #93 looks to be further into the review process?

mheon commented 2 years ago

CI is failing, seems unrelated. @Luap99 Is this the same thing that hit Podman CI?

Luap99 commented 2 years ago

It related but no the same problem. The go version is just to old to compile ginkgo.

Looks like the VM images are very old cc @cevich

cevich commented 2 years ago

Looks like the VM images are very old

Yes, we just got buildah and skopeo updated last week. I need to make a jira card for updating all the others (there's a lot of them).

cevich commented 2 years ago

https://github.com/containers/dnsname/pull/95

apetryla commented 2 years ago

What's the status of this? Just encountered this issue myself.

mheon commented 2 years ago

This repo (and dnsname) are deprecated. We've switched all development efforts over to the Netavark network stack.

@Luap99 @baude Should we consider archiving this repo?

cevich commented 2 years ago

If so, please LMK. I need to know to disable all the CI stuffs.

Luap99 commented 2 years ago

I think CI can be disabled. Not so sure about archiving, dnsname is still shipped in distros and we might need to provide CVE fixes in the future?

cevich commented 2 years ago

Oh right, well if there's any CVE change, we need to keep CI alive then.