containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

Helper function to check if the volume is a regular or thin volume #11

Closed shishir-a412ed closed 8 years ago

shishir-a412ed commented 8 years ago

Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com

shishir-a412ed commented 8 years ago

When creating a snapshot volume I need to know if my origin volume was a regular or thin volume. Regular volume snapshots needs size (mandatory) to be passed, however thin volume snapshots don't.

This PR is needed to support https://github.com/projectatomic/docker-lvm-plugin/pull/9

ping @rhatdan @runcom

Shishir

runcom commented 8 years ago

SGTM

shishir-a412ed commented 8 years ago

LGTM. Merging.