search

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

PART 2: Add support for thinly-provisioned volumes and snapshots #21

Closed shishir-a412ed closed 8 years ago

shishir-a412ed commented 8 years ago

Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com

shishir-a412ed commented 8 years ago

@cschauer So I think I got this completed :) If you have sometime, can you try it out and see if it covers all the use cases.

There is a small Caveat: Since now there are changes to the in-memory store (which is also persisted on disk). You might have to start with a new environment i.e. no volumes present using lvm driver. Now if you have this (docker-lvm-plugin) running in production, I can help you update the db file manually with new fields {Type, Source}.

db file is: /var/lib/docker-lvm-plugin/lvmVolumesConfig.json

Meanwhile I will try to update the doc and man pages.

Shishir

shishir-a412ed commented 8 years ago

@cschauer On second thought (n After discussing it with @rhatdan ) I don't think this should affect lvm volumes created before these features (thin devices and snapshots) were introduced.

So just try it out, and let me know if you face any issues.

Thanks ! Shishir

cschauer commented 8 years ago

@shishir-a412ed Thanks! I'll test it out and report back.

shishir-a412ed commented 8 years ago

@cschauer Just checking if you got a chance to look at this.

Shishir

shishir-a412ed commented 8 years ago

@cschauer Any updates :)

Shishir

shishir-a412ed commented 8 years ago

LGTM. Merging.