Create BINDIR on install

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes

GNU Lesser General Public License v3.0

155 stars 64 forks source link

Closed kalahari closed 7 years ago

kalahari commented 7 years ago

This addressed #26

shishir-a412ed commented 7 years ago

LGTM.

@rhatdan PTAL.

Shishir

rhatdan commented 7 years ago

That works, but you probably need something similar for the MANDIR

+   install -d -m 0755 ${BINDIR}
    install -m 755 $(BINARY) $(BINDIR)
    install -m 644 docker-lvm-plugin.8 ${MANINSTALLDIR}/man8/

Could be

    install -D -m 755 $(BINARY) $(BINDIR)/$(BINARY)
    install -D -m 644 docker-lvm-plugin.8 ${MANINSTALLDIR}/man8/docker-lvm-plugin.8

kalahari commented 7 years ago

I added the -D flag to all installs, and removed all directory installs. Does the config file need to be installed executable?

rhatdan commented 7 years ago

No. It should not be executable.

kalahari commented 7 years ago

I updated the Makefile to install the config file without execute bits.

rhatdan commented 7 years ago

LGTM