search

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

Update count in-memory store only when Mount and Unmount operations have completed successfully #35

Closed shishir-a412ed closed 7 years ago

shishir-a412ed commented 7 years ago

Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com

shishir-a412ed commented 7 years ago

ping @rhatdan

rhatdan commented 7 years ago

Does this relate to a bugzilla?

shishir-a412ed commented 7 years ago

@rhatdan No, but if there was an error in Mount and Unmount operations, the in-memory store was getting updated before the operations {Mount, Unmount} and before it could save the new state to the disk, it would error out. The in-memory store and on disk state would then get out of sync. This PR addresses that.

Shishir

rhatdan commented 7 years ago

LGTM

rhatdan commented 7 years ago

Fix the commit message to match what you just said, and we can merge.

Do multi line

shishir-a412ed commented 7 years ago

@rhatdan Fixed. Merging this PR.

Shishir

rhatdan commented 7 years ago

Fix first line so it does not go over multiple lines. Something short like

Update count in-memory store on successful mount/unmount

shishir-a412ed commented 7 years ago

@rhatdan Fixed. PTAL.

Shishir