search

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

Derive CreatedAt from lvdisplay #61

Closed ashald closed 5 years ago

ashald commented 5 years ago

The Get handler extracts volume creation date from lvdisplay output and uses it to set CreatedAt field.

Fixes #58.

ashald commented 5 years ago

It turns out that reference implementation uses local time rather than UTC - will do the same here.

shishir-a412ed commented 5 years ago

@Ashald

I went through the PR, and felt It needed some code reorganization (and cleanup). Also, go vendoring needed to be fixed since the current vendored version of go-plugin-helpers doesn't have CreatedAt as part of the Volume struct.

I have created a follow up PR here: https://github.com/projectatomic/docker-lvm-plugin/pull/68

PR for updating godeps is here: https://github.com/projectatomic/docker-lvm-plugin/pull/67

Can you review the PR once (#68)? If it looks good, we can close this PR and merge #68 instead.

ashald commented 5 years ago

@shishir-a412ed yeah, sure! I went through #68 and it seems to me work in the same way but just handles the change to lvdisplayGrep in a little bit different way. I did not notice anything of concern with #68 and would be happy if that one was merged instead. Thanks!