Default to 'yes' for lvcreate prompts

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes

GNU Lesser General Public License v3.0

155 stars 64 forks source link

Default to 'yes' for lvcreate prompts #63

Closed ashald closed 5 years ago

ashald commented 5 years ago

Currently lvcreate detects xfs signature at the beginning of the volume and asks for a confirmation to zero it (the default behavior). Because there is no stdin attached - confirmation is not given and lvcreate just creates the volume without zeroing its beginning. This in turn leads to an error with mkfs.

Adding -y to lvcreate forces a yes answer to zeriong confirmation prompt and makes sure that volume beginning will be properly cleared.

ashald commented 5 years ago

This pull requests presumably is an alternative fix for the same issue as #62. Either of them or both can be merged to address the underlying issue.

shishir-a412ed commented 5 years ago

LGTM.

ashald commented 5 years ago

Yay! 🎉