containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

lvremove without lvchange #64

Closed mortya closed 4 years ago

mortya commented 5 years ago

I notice that the code does an lvremove --force $device instead of lvchange -a n $device followed by lvremove $device. I think the latter is usually preferred. This might be deliberate on your part, though, if you want to do the remove as a single atomic action. Heads up, just in case.

shishir-a412ed commented 5 years ago

@mortya PR's are welcome :)

shishir-a412ed commented 4 years ago

Keeping it as an atomic operation lvremove --force $device for now.