search

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

build broken by upstream go-connections dependency #74

Closed nickbreen closed 5 years ago

nickbreen commented 5 years ago

Build fails due to this up-stream error: https://github.com/docker/go-connections/issues/60 and is fixed in 61039d0834e53e8ae181e064229a9e79d7cd77aa or later.

$ make
go-md2man -in man/docker-lvm-plugin.8.md -out docker-lvm-plugin.8
/usr/bin/go build -o docker-lvm-plugin .
# github.com/docker/go-connections/sockets
../../go/src/github.com/docker/go-connections/sockets/sockets.go:34:26: dialer.DialContext undefined (type proxy.Dialer has no field or method DialContext)
../../go/src/github.com/docker/go-connections/sockets/sockets_unix.go:24:28: undefined: context
make: *** [Makefile:19: lvm-plugin-build] Error 2

Tried with both go 1.10 on ubuntu disco, and golang/1.8 and golang/1.12.5 docker containers.

shishir-a412ed commented 5 years ago

@nickbreen Just tried this with go version go1.12.5 linux/amd64 (with go modules). Works for me.

shishir@shishir-Standard-PC-i440FX-PIIX-1996:~/go/src/github.com/docker-lvm-plugin-1$ make
go-md2man -in man/docker-lvm-plugin.8.md -out docker-lvm-plugin.8
/usr/bin/go build -o docker-lvm-plugin .
go: finding github.com/containerd/continuity v0.0.0-20180322171221-3e8f2ea4b190
go: finding github.com/Microsoft/go-winio v0.0.0-20180116223503-7da180ee92d8
go: finding github.com/docker/go-plugins-helpers v0.0.0-20181025120712-1e6269c305b8
go: finding github.com/docker/go-connections v0.0.0-20180228141015-7395e3f8aa16
go: finding github.com/opencontainers/image-spec v0.0.0-20180411145040-e562b0440392
go: finding github.com/Sirupsen/logrus v0.0.0-20180329225952-778f2e774c72
go: finding github.com/coreos/go-systemd v0.0.0-20180409111510-d1b7d058aa2a
go: finding golang.org/x/net v0.0.0-20180406214816-61147c48b25b
go: finding golang.org/x/sys v0.0.0-20180414092825-2281fa97ef7b
go: finding golang.org/x/crypto v0.0.0-20180411161317-d6449816ce06
go: finding github.com/sirupsen/logrus v0.0.0-20180329225952-778f2e774c72
go: finding github.com/opencontainers/go-digest v0.0.0-20170607195333-279bed98673d
go: finding github.com/pkg/errors v0.0.0-20180311214515-816c9085562c
go: finding github.com/docker/go-units v0.0.0-20180212134657-47565b4f722f
go: finding github.com/docker/docker v0.0.0-20180415161252-ea579a619452
go: downloading github.com/docker/go-plugins-helpers v0.0.0-20181025120712-1e6269c305b8
go: downloading github.com/docker/docker v0.0.0-20180415161252-ea579a619452
go: downloading github.com/sirupsen/logrus v0.0.0-20180329225952-778f2e774c72
go: extracting github.com/docker/go-plugins-helpers v0.0.0-20181025120712-1e6269c305b8
go: extracting github.com/sirupsen/logrus v0.0.0-20180329225952-778f2e774c72
go: downloading github.com/coreos/go-systemd v0.0.0-20180409111510-d1b7d058aa2a
go: downloading github.com/docker/go-connections v0.0.0-20180228141015-7395e3f8aa16
go: downloading golang.org/x/crypto v0.0.0-20180411161317-d6449816ce06
go: downloading golang.org/x/sys v0.0.0-20180414092825-2281fa97ef7b
go: extracting github.com/docker/go-connections v0.0.0-20180228141015-7395e3f8aa16
go: downloading golang.org/x/net v0.0.0-20180406214816-61147c48b25b
go: extracting github.com/coreos/go-systemd v0.0.0-20180409111510-d1b7d058aa2a
go: extracting golang.org/x/crypto v0.0.0-20180411161317-d6449816ce06
go: extracting golang.org/x/sys v0.0.0-20180414092825-2281fa97ef7b
go: extracting golang.org/x/net v0.0.0-20180406214816-61147c48b25b
go: extracting github.com/docker/docker v0.0.0-20180415161252-ea579a619452
go: downloading github.com/pkg/errors v0.0.0-20180311214515-816c9085562c
go: downloading github.com/docker/go-units v0.0.0-20180212134657-47565b4f722f
go: downloading github.com/containerd/continuity v0.0.0-20180322171221-3e8f2ea4b190
go: downloading github.com/opencontainers/image-spec v0.0.0-20180411145040-e562b0440392
go: extracting github.com/pkg/errors v0.0.0-20180311214515-816c9085562c
go: extracting github.com/docker/go-units v0.0.0-20180212134657-47565b4f722f
go: extracting github.com/opencontainers/image-spec v0.0.0-20180411145040-e562b0440392
go: downloading github.com/opencontainers/go-digest v0.0.0-20170607195333-279bed98673d
go: extracting github.com/opencontainers/go-digest v0.0.0-20170607195333-279bed98673d
go: extracting github.com/containerd/continuity v0.0.0-20180322171221-3e8f2ea4b190

Once #77 is merged to master. This should work.