make file assumes go-md2man is present and in path

containers / docker-lvm-plugin

Docker volume plugin for LVM volumes

GNU Lesser General Public License v3.0

155 stars 64 forks source link

Closed nickbreen closed 5 years ago

nickbreen commented 5 years ago

Problem encountered in golang/1.8 and golang/1.12.5 docker containers, and also on ubuntu disco.

On ubuntu apt install go-md2man provided the tool.

The Makefile should include an env/var for go-md2man as it does with GOLANG.

shishir-a412ed commented 5 years ago

Even if I add the env/var for go-md2man in the Makefile, something like:

GOLANG ?= /usr/bin/go
GOMD2MAN ?= /usr/bin/go-md2man

you would still have to install go-md2man. If go-md2man is missing on the system, it will throw an error.

Once you install the tool, it's by default in the $PATH (/usr/bin), so no variable needed in the Makefile.