containers / docker-lvm-plugin

Docker volume plugin for LVM volumes
GNU Lesser General Public License v3.0
155 stars 64 forks source link

Throw error if volume size is <16M. #80

Closed shishir-a412ed closed 5 years ago

shishir-a412ed commented 5 years ago

Fixes #60

Signed-off-by: Shishir Mahajan shishirm@nvidia.com

shishir-a412ed commented 5 years ago

@rhatdan Please review. /cc @angermueller

[root@localhost docker-lvm-plugin]# docker volume create -d lvm --opt size=20Mbs --name foobar
Error response from daemon: create foobar: VolumeDriver.Create: invalid size: '20Mbs'
[root@localhost docker-lvm-plugin]# docker volume create -d lvm --opt size=15M --name foobar
Error response from daemon: create foobar: VolumeDriver.Create: Error creating LVM volume, minimum expected size is 16M
rhatdan commented 5 years ago

LGTM