search

containers / fuse-overlayfs

FUSE implementation for overlayfs
GNU General Public License v2.0
522 stars 84 forks source link

Prefer user.containers.override_stat over user.fuseoverlayfs. #422

Closed akihikodaki closed 3 months ago

akihikodaki commented 3 months ago

See https://github.com/containers/storage/pull/1953#discussion_r1631219565

akihikodaki commented 3 months ago

The fallback code was wrong so I fixed it with commit 9aa27e5d659923576a0bfa4871634ed3f1544467.

I also added changes to fix xattrs on network storage with commit 78711d809e228c7391871f6a7bf927bab79083a3 and 75a3c4b156b1424e0f5d25135f4e43b46374c5b8. You can pull the earlier patches first if you like.

giuseppe commented 3 months ago

I'll merge once CI is green. Thanks for working on this!

I am wondering at this point, if it would be easier to always use "user.containers. and avoid this madness (that I am responsible for) of having so many ways to do the same thing

akihikodaki commented 3 months ago

Added tests with commit 80ebaf32f8924b5e8c9a01961ecb7fb806ca0156. I merged #420 and #421 into this pull request because they would conflict.

akihikodaki commented 3 months ago

I opened #424 to fix tests.

Commit 2267664c7660f2d28b561724e51ad32c3ee0b169 and 80ebaf32f8924b5e8c9a01961ecb7fb806ca0156 only work with user.containers. because I also thought there is no point supporting the other prefixes for anything new.

giuseppe commented 3 months ago

does this PR need a rebase?

akihikodaki commented 3 months ago

Rebased and fixed tests.