search

containers / gvisor-tap-vsock

A new network stack based on gVisor
Apache License 2.0
269 stars 50 forks source link

go.mod: github.com/u-root/uio vd2acac8f3701 #356

Closed loong-hy closed 4 months ago

loong-hy commented 6 months ago

This is fix build error in loong64

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loong-hy Once this PR has been reviewed and has the lgtm label, please assign baude for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cfergeau commented 6 months ago

For what it's worth, I'd have a preference for not updating to latest u-root/uio which requires golang 1.21, but to update to a slightly older version which still builds with loong64. I've tried this in https://github.com/cfergeau/gvisor-tap-vsock/commit/62e19dd7d4c7455be3ceff36aa16723875abce86

If you think we should go with your version, can you add a Signed-off-by tag as described here https://github.com/containers/gvisor-tap-vsock/pull/356/checks?check_run_id=24844594438 ?

cfergeau commented 6 months ago

For what it's worth, I'd have a preference for not updating to latest u-root/uio which requires golang 1.21, but to update to a slightly older version which still builds with loong64. I've tried this in cfergeau@62e19dd

Using an older u-root/uio version would allow us to keep golang 1.20 compatibility. However, https://github.com/containers/gvisor-tap-vsock/pull/350 will also introduce a go 1.21 requirement, so this is less of a problem.

openshift-merge-robot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cfergeau commented 5 months ago

I've opened https://github.com/containers/gvisor-tap-vsock/pull/366 to try and solve this issue.

gbraad commented 4 months ago

I approved the PR of @cfergeau, but am unable to verify this. The only Loongson (龙芯) I have is the much older Loongson 3A ;-). So I only based this on the dependencies and upgrade for our current primary archs.

cfergeau commented 4 months ago

Closing as #366 has been merged.