search

containers / gvisor-tap-vsock

A new network stack based on gVisor
Apache License 2.0
269 stars 50 forks source link

test: Use ubuntu runner instead of macos runner for tests #359

Closed cfergeau closed 6 months ago

cfergeau commented 6 months ago

M1 macos runners can't build our test code, and the M1 runners don't support nested virt, which is required by make test Since I expect in the future the x86_64 macos runners to go away, and since the ubuntu runners now support nested virt, this commit uses an ubuntu runner to run make test.

cfergeau commented 6 months ago

I think the packer failures on centos stream 8 and fedora eln are unrelated to this PR.

praveenkumar commented 6 months ago

/lgtm /approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment