Fix consistent udp packet loss after the proxy read loop stopped

[fatanugraha]

Currently we never close the tcpip.Endpoint that we created when we get *udp.ForwarderRequest. This causes all packets that is sent by the same src ip:port after we return from the UDPProxy.Run to be "dropped".

By closing the endpoint, we will get new forwarder request after we return from UDPProxy.Run so we can process new packets.

Here's my reproduction code:

1. Reuse the same local address when sending udp requests
2. Send one DNS request (success)
3. wait until UDPProxy.Run to return (after 90s)
4. Send one DNS request (failed)

package main

import (
    "context"
    "fmt"
    "net"
    "time"
)

func main() {
    r := &net.Resolver{
        PreferGo: true,
        Dial: func(ctx context.Context, network, address string) (net.Conn, error) {
            addr, err := net.ResolveUDPAddr("udp", "192.168.5.1:40001")
            if err != nil {
                panic(err)
            }

            d := net.Dialer{
                Timeout:   time.Millisecond * time.Duration(10000),
                KeepAlive: -1,
                LocalAddr: addr,
            }

            conn, err := d.DialContext(ctx, network, "8.8.8.8:53")
            if err != nil {
                panic(err)
            }

            return conn, err
        },
    }

    lookup := func() {
        _, err := r.LookupIP(context.Background(), "ip4", "www.google.com")
        if err != nil {
            fmt.Println("err", err)
        } else {
            fmt.Println("ok")
        }
    }

    lookup()                     // ok
    time.Sleep(95 * time.Second) // wait for the UDPConnTimeout
    lookup()                     // this will fail
}

[fatanugraha]

/assign cfergeau

[fatanugraha]

/cc baude cfergeau

[evidolob]

@fatanugraha I was trying to test this PR. I try to run test that you provided and it works fine(I don't get any errors, just two ok). I try that on macOS and fedora 40. So I was wondering is I missing something?

[fatanugraha]

Hi @evidolob I've put more detailed reproduction steps here: https://github.com/fatanugraha/gvisor-tap-proxy-393

Do let me know if you have further questions 🙇

attached debug logs from gvproxy (notice that the dns query from the same local addr starts failing after this log is printed DEBU[0122] Stopping udp proxy (read udp 8.8.8.8:53: i/o timeout)

gvproxy.log

capture.pcap.zip

[evidolob]

@cfergeau I can verify that problem described in this PR description exist, and PR indeed fix it.

[cfergeau]

I forced pushed to the branch to fix a few typos in the comment. /lgtm /approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, evidolob, fatanugraha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[cfergeau]

I wonder if this PR could help with https://github.com/containers/gvisor-tap-vsock/issues/387 ? (dropping a note here as I can't test/look closely now)

[cfergeau]

I wonder if this PR could help with #387 ? (dropping a note here as I can't test/look closely now)

Yevhen tested this, and this does not help.