search

containers / gvisor-tap-vsock

A new network stack based on gVisor
Apache License 2.0
269 stars 50 forks source link

packit: Don't attempt to build on f39 #400

Closed cfergeau closed 2 months ago

cfergeau commented 2 months ago

It only has go 1.21 while we switched to go 1.22, so gvisor-tap-vsock fails to build on f39. I don't expect significant changes to gvisor-tap-vsock during the remaining f39 lifetime, at worse podman in f39 can keep using an older gvproxy release.

cfergeau commented 2 months ago

I added f40, but we can revert this commit once f41 is released.

praveenkumar commented 2 months ago

I added f40, but we can revert this commit once f41 is released.

But even f41 release, f-39 will be EOL but not f-40 so may be we should keep using it until we again update go version which is not built for f-40 :)

cfergeau commented 2 months ago

I added f40, but we can revert this commit once f41 is released.

But even f41 release, f-39 will be EOL but not f-40 so may be we should keep using it until we again update go version which is not built for f-40 :)

If we revert, we get back to fedora-all, which will be f40, f41 and rawhide (and f42 after branching)

praveenkumar commented 2 months ago

/lgtm /approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment