search

containers / gvisor-tap-vsock

A new network stack based on gVisor
Apache License 2.0
269 stars 50 forks source link

Avoid crash with empty resolv.conf #420

Closed siretart closed 3 days ago

siretart commented 2 weeks ago

Fixes: #417 Signed-off-by: Reinhard Tartler siretart@gmail.com

cfergeau commented 1 week ago

There is also this lint failure to fix:

cd tools && GOBIN="/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin" go install github.com/golangci/golangci-lint/cmd/golangci-lint
"/home/runner/work/gvisor-tap-vsock/gvisor-tap-vsock/tools/bin"/golangci-lint run
pkg/services/dns/dns_config_unix.go:6: File is not `goimports`-ed (goimports)
    "errors"
make: *** [Makefile:49: lint] Error 1
cfergeau commented 3 days ago

/lgtm /approve

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, siretart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/gvisor-tap-vsock/blob/main/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment