containers / image

Work with containers' images
Apache License 2.0
862 stars 376 forks source link

Update to Go1.21 #2377

Closed mtrmac closed 5 months ago

mtrmac commented 5 months ago

… primarily because some dependencies started to require it: if we ever needed to quickly update a dependency for a vulnerability fix, we might have to update to Go 1.21 on a short notice, or fork the dependency.

And then bump dependencies which we have been holding back:

Cc: @jnovy @lsm5 @cevich @TomSweeneyRedHat

mtrmac commented 5 months ago

Note to self: Afterwards we should github.com/letsencrypt/boulder to avoid a dependency on no-longer-maintained gopkg.in/go-jose/go-jose.v2. (We don’t call it though that path AFAIK, still, we include it.)

mtrmac commented 5 months ago

Cross-linking for visibility: https://github.com/containers/skopeo/pull/2297#issuecomment-2057502035 says we need an update to the Renovate config (affecting also repos using c/image).

mtrmac commented 5 months ago

(Marking as draft to make sure we have a decision the Renovate configuration first; I understand Renovate would immediately start failing otherwise.)

cevich commented 5 months ago

(cross-post / copy)

I don't believe it will fail, it will simply (and mostly silently) refuse to open any module update PRs which also require a bump of go 1.21.

cevich commented 5 months ago

Ref: https://github.com/containers/automation/pull/189

rhatdan commented 5 months ago

LGTM