search

containers / image_build

Monorepo menagerie of container images and associated build automation
Apache License 2.0
12 stars 5 forks source link

Fix cron task skipping builds #33

Closed cevich closed 5 months ago

cevich commented 5 months ago

Previously, it was possible for the cron task to skip all builds given the changed-file condition would always evaluate True. Fix this by also requiring the matrix element's skip to also require running in a PR context. Also add a comment warning future maintainers about the re-use of the skip's via the pbs_images YAML anchor/alias.

Fixes https://github.com/containers/podman/issues/22861

Also ref. https://github.com/containers/image/issues/2203#issuecomment-2142072150

cevich commented 5 months ago

Note: After merging, initiated a manual build to refresh all images (None were built in the last ~24 days).

mtrmac commented 5 months ago

Thanks!