initoverlayfs-install: generic improvements

dougsland commented 1 year ago

split extract_initrd_into_initoverlayfs()
add exec_cmd() to validate commands
remove unneeded |--* in case statement
use less verbose removing the requirement set -ex
replace initoverlayfs_conf with constant
remove unused no_kern
fix some shellcheck warnings

Fixes: https://github.com/containers/initoverlayfs/issues/11 Fixes: https://github.com/containers/initoverlayfs/issues/12

dougsland commented 1 year ago

Just spend some time on the weekend reading and testing the bin/initoverlayfs-install. This is a generic improvements, nothing fancy or rocket science. Hope it make sense and make the code easier for maintenance.

dougsland commented 1 year ago

The CI/CD still failing, need to address some others scripts this week.

dougsland commented 1 year ago

All good:

# ./bin/initoverlayfs-install
<snip>
dracut: *** Creating image file '/boot/initramfs-6.5.5-300.fc39.x86_64.img' ***
dracut: Using auto-determined compression method 'pigz'
dracut: *** Creating initramfs image file '/boot/initramfs-6.5.5-300.fc39.x86_64.img' done ***

initoverlayfs]# du -sh /boot/init*
149M    /boot/initoverlayfs-123.img
27M /boot/initoverlayfs-6.5.5-300.fc39.img
149M    /boot/initoverlayfs-6.5.5-300.fc39.x86_64.img
149M    /boot/initoverlayfs-6.5.5-300.img
28M /boot/initoverlayfs-foo.img
81M /boot/initramfs-0-rescue-285b2edb8ad94c7381215fd5720afd54.img
34M /boot/initramfs-6.4.12-200.fc38.x86_64.img
34M /boot/initramfs-6.5.5-200.fc38.x86_64.img
13M /boot/initramfs-6.5.5-300.fc39.x86_64.img

ericcurtin commented 1 year ago

Only gave a skip as I'm off, but looks cleaner

ericcurtin commented 1 year ago

shellcheck failed, but it's failing everywhere at present

containers / initoverlayfs

initoverlayfs-install: generic improvements #10