search

containers / initoverlayfs

GNU General Public License v2.0
35 stars 9 forks source link

Add volatile keyword to mount #17

Closed ericcurtin closed 7 months ago

ericcurtin commented 7 months ago

initoverlayfs is designed to be throwaway, the data need not be synced, the volatile keyword makes the boot faster, by not demanding sync. Tested on Raspberry Pi 4.

rhatdan commented 7 months ago

LGTM @giuseppe FYI

ericcurtin commented 7 months ago

Yup I noticed this "volatile" was your kernel contribution @giuseppe .

We should probably have volatile on for other throwaway filesystems like:

rpm-ostree usroverlay

and

bootc usroverlay

also. There would be some performance savings there too (it should be added in a way that supports kernels without "volatile" support also I guess if it was to be added for usroverlay). Even though usroverlay typically isn't a performance critical use case, but who knows, for some people it might be?

Btw, I'm kind of assuming "volatile" made the RHEL 9 kernel in this PR @giuseppe @rhatdan ... Is that true? I tested this on Fedora.

ericcurtin commented 7 months ago

@giuseppe @rhatdan any other recommendations/options/etc. that you are aware of that make IO faster feel free to suggest by the way...

giuseppe commented 7 months ago

volatile should be in RHEL 9.

Would it make sense to retry the mount command without volatile if mount(2) fails with EINVAL?

ericcurtin commented 7 months ago

Added reattempt without "volatile" on EINVAL

rhatdan commented 7 months ago

LGTM