Closed Yarboa closed 11 months ago
This is really neat @Yarboa
LGTM
This should work after we merge this I think:
https://github.com/containers/initoverlayfs/pull/30
we need PR number 30 anyway for unaccounted devices.
I think a rebase should fix this @Yarboa
LGTM as far as packit changes are concerned.
You might wanna also switch to autospec to get rid of the changelog burden in rpm spec (doesn't concern this PR).
/packit test
Account mwperina has no write access nor is author of PR!
LGTM
~I suspect there is new issue with F39. checking manually I will add f38 also, i verified it manually. I thing it is the latest updates from eric.~
Verified manually with 6.5.6-300.fc39.x86_64 public runch is down i think https://status.testing-farm.io/affected/public-ranch/
I will try to trigger later
On this @mwperina
"ccount mwperina has no write access nor is author of PR!"
I added you as a member with write access, I think you just have to accept.
/packit test
Account mwperina has no write access nor is author of PR!
/packit test
On this @mwperina
"ccount mwperina has no write access nor is author of PR!"
I added you as a member with write access, I think you just have to accept.
I probably missed some email, but I was able to find out the invite in my organizations and it works fine. Thanks Eric.
There is an issue with reboot
00:00:25 /integration/tests/boot-validation [1/1]
00:00:25 errr /integration/tests/boot-validation (on default-0) (reboot timeout) [1/1]
fail: Failed to pull workdir from the guest. This usually means that login as 'root' to the guest does not work
I will have to reserve AWS and debug
Ok i was running it manually on testing farm https://artifacts.dev.testing-farm.io/a933c23c-ec8d-45b0-9002-cc75814415ae/ It seems to be TF issue, lets wait to this PR to pass all tests
Interesting with packit and generated rpms it is failing so on AWS 0.98 is failing while 0.96 is passing.
If we rebase this it might just work @Yarboa
I just noticed that RPMs are generated as they would be a stable release (initoverlayfs-0.98-1.el9.src.rpm
) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm
). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers
I just noticed that RPMs are generated as they would be a stable release (
initoverlayfs-0.98-1.el9.src.rpm
) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm
). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers
@mwperina thanks do you refer running to something like this ? build-scripts/version.sh
I just noticed that RPMs are generated as they would be a stable release (
initoverlayfs-0.98-1.el9.src.rpm
) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm
). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers@mwperina thanks do you refer running to something like this ? build-scripts/version.sh
So BlueChi has that support, so if you want to inspire, please take a look at those files:
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-rpm.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-srpm.sh
Above 2 files are not needed for packit, they are here for previous GH build/test integration and for local command line convenience.
Below files are required for packit integration: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-archive.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/version.sh https://github.com/eclipse-bluechi/bluechi/blob/main/.packit.yml#L20
But maybe it can be simplifed for initoverlayfs, which is much smaller project
I just noticed that RPMs are generated as they would be a stable release (
initoverlayfs-0.98-1.el9.src.rpm
) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm
). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers@mwperina thanks do you refer running to something like this ? build-scripts/version.sh
So BlueChi has that support, so if you want to inspire, please take a look at those files:
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-rpm.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-srpm.sh
Above 2 files are not needed for packit, they are here for previous GH build/test integration and for local command line convenience.
Below files are required for packit integration: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-archive.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/version.sh https://github.com/eclipse-bluechi/bluechi/blob/main/.packit.yml#L20
But maybe it can be simplifed for initoverlayfs, which is much smaller project
Thanks, much appreciated
Unfortunately it's not enough, you still need to convert spec file to a template and replace version/release in this template per build: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh
I wish there was a auto-merge if build is green button here like we have in gitlab, it's useful...
I found it in settings and turned it on, maybe the next PR will have the option
Unfortunately it's not enough, you still need to convert spec file to a template and replace version/release in this template per build: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh
Noticed that. yes, lets wait
Now it looks good 'package_version': '0.98-0.202312141231.git4c998f9',
Tests are run by packit through tmt in testsing-farm Adding integration plan and tier-0 test verifying initoverlayfs setup
resolve #23