search

containers / initoverlayfs

GNU General Public License v2.0
35 stars 9 forks source link

Update spec file to new release 0.98 for package #39

Closed smooge closed 7 months ago

smooge commented 7 months ago

Make change to spec file to reflect version 0.98

dougsland commented 7 months ago

@smooge @ericcurtin not sure if I follow. We never released v0.97 officially. At least, there is no release found in github release page, the last is v0.96. "Comment from the unskilled drummer"

ericcurtin commented 7 months ago

Yup @dougsland we never really released 0.97, we intended to, but never got around to it, so we are skipping it and going to 0.98 , it's ok as long as we keep going up in versions... Hey IP, went from IPv4 to IPv6 right? :smile:

ericcurtin commented 7 months ago

@smooge could we remove the shellcheck changes from this PR. We already have another PR for that:

https://github.com/containers/initoverlayfs/pull/24

ericcurtin commented 7 months ago

Another thing that's very important is testing shellcheck changes...

Making suggested shellcheck fixes can break things, I'm one of the guilty parties who has broken scripts from making shellcheck changes... Not in this project but others, thankfully it never made the main branch...

And we can't rely on CI to test shell changes yet, because it's not set up to execute any shell scripts or C code yet, so changes have to be tested manually...

ericcurtin commented 7 months ago

We can merge https://github.com/containers/initoverlayfs/pull/24 without the extensive CI, we just have to make sure the changes are manually tested, because none of these shell scripts are executed in CI yet...

smooge commented 7 months ago

I can undo the shellcheck changes and just put "# shellcheck disable=SC????,SC2016 to allow testing cleanup.

smooge commented 7 months ago

I am closing this to do a cleaner fix