search

containers / initoverlayfs

GNU General Public License v2.0
40 stars 8 forks source link

install: detect where the initramfs exists #43

Closed dougsland closed 11 months ago

dougsland commented 11 months ago

Helps distros which the file is not on /boot dir.

ericcurtin commented 11 months ago

Linked PR: https://github.com/coreos/rpm-ostree/pull/4721/files

We can use this detection technique for now, but I do wonder if there are more changes, rather than detection, should we have some flag we pass to initoverlayfs-install like, so we call in the other PR like:

initoverlayfs-install -r

with -r being --rpm-ostree-preptree or whatever that stage is called. That's more solid than detection.

But I'm happy to merge this now if needs be so we can keep moving forward. Just say the word!

ericcurtin commented 11 months ago

@Yarboa we will get to that bugfix, this is unrelated, it doesn't make that problem worse, but this PR will help continue our rpm-ostree efforts if we merge this...

But @dougsland might be just as happy integrating this locally for now...

Yarboa commented 11 months ago

@Yarboa we will get to that bugfix, this is unrelated, it doesn't make that problem worse, but this PR will help continue our rpm-ostree efforts if we merge this...

But @dougsland might be just as happy integrating this locally for now...

Did i get it correct?, Does PR enables rpm-ostree to call inioverlayfs-install during rpm-ostree build?

First conversation, mislead me :/ 

Helps distros which the file is not on /boot dir.
ericcurtin commented 11 months ago

@Yarboa yeah this use case is different to a human running executing initoverlayfs-install, this is building the image on the rpm-ostree build server use case