search

containers / initoverlayfs

GNU General Public License v2.0
35 stars 9 forks source link

Fix typo in README.md #86

Closed firasuke closed 4 weeks ago

dougsland commented 1 month ago

LGTM @ericcurtin

rhatdan commented 1 month ago

@firasuke Thanks But you need to sign your commits git commit -a --amend -s git push --force

firasuke commented 1 month ago

No worries, but this was done as a quick fix on GitHub's UI, and I didn't have the repository cloned, hence the lack of signature.

ericcurtin commented 1 month ago

@firasuke congrats, you're our first external contributor (I think if memory serves me right).

Once you fix DCO, it will be an insta-merge.

Just to give an update on this in general, I haven't been able to continue this for a while, got pulled into other priorities.

I should give an update on where this may go in future.

We planned for this to be useful for general initial filesystems in Automotive, but in the meantime we have had great joy with device-specific mini-initramfses. Using these two things:

https://gitlab.com/CentOS/automotive/rpms/dracut-automotive https://gitlab.com/CentOS/automotive/rpms/util-linux-automotive

Which is not something we typically do in Fedora or CentOS Stream. But our Automotive osbuild's get very device specific, so this technique is working well for us there right now.

There's folk working on Linux as a bootloader, and they may find this interesting though, there's a multiple use-cases for this potentially when we get more time to work on this.

firasuke commented 4 weeks ago

@firasuke congrats, you're our first external contributor (I think if memory serves me right).

Thanks for the congratulations! It's just a minor typo so it's not a big deal. I also apologize for polluting the PR history with another identical PR.

Keep up the good work!