search

containers / krunvm

Create microVMs from OCI images
Apache License 2.0
1.41k stars 42 forks source link

Fix build failure on macOS due to missing Inspect case #25

Closed c3d closed 2 years ago

c3d commented 2 years ago

Add the missing Inspect case in the macOS configuration.

Fixes: #24

Signed-off-by: Christophe de Dinechin dinechin@redhat.com

c3d commented 2 years ago

This fails the DCO check, apparently complaining that there is a missing "Signed-off-by", but it's there. Not sure why 😄

slp commented 2 years ago

Ouch, sorry, I've only seen your PR after merging mine... :-(

The DCO tests fails because the author in the commit doesn't match the signature:

Commit sha: [91f045a](https://github.com/containers/krunvm/pull/25/commits/91f045a791f60b4685a20b8fc1a67acca3c738a9), Author: Christophe de Dinechin, Committer: Christophe de Dinechin; Expected "Christophe de Dinechin [christophe@dinechin.org](mailto:christophe@dinechin.org)", but got "Christophe de Dinechin [dinechin@redhat.com](mailto:dinechin@redhat.com)".