search

containers / krunvm

Create microVMs from OCI images
Apache License 2.0
1.41k stars 42 forks source link

Generated help for `changevm` subcommand is incorrect #32

Closed aeons closed 2 years ago

aeons commented 2 years ago

The help for changevm shows that the options should come before the name.

$ krunvm changevm --help             
krunvm-changevm 
Change the configuration of a microVM

USAGE:
    krunvm changevm [FLAGS] [OPTIONS] <NAME>
...

However, doing this results in a contradictory error message:

$ krunvm changevm --port 5432:5432 db
error: The following required arguments were not provided:
    <NAME>

USAGE:
    krunvm changevm <NAME> --port <port>...
...
slp commented 2 years ago

Good catch! Turns out it was a problem with clap's argument definition. Fixed now.