containers / krunvm

Create microVMs from OCI images
Apache License 2.0
1.41k stars 42 forks source link

Add -f / --force option to delete #44

Open c3d opened 1 year ago

c3d commented 1 year ago

There are cases where krunvm fails to delete a VM, e.g. because the corresponding container no longer exists. Add a --force (or -f) option to the delete subcommand that forces deletion of the VM configuration in that case.

Fixes: #42

Lyamc commented 7 months ago

Btw I've tested this, and it worked, although for some reason it creates an error twice:

root@macbookair:~/Build/krunvm/target/release# ./krunvm delete asahi-krun
Error: error unmounting container asahi-krun-working-container: container not known
buildah returned an error: 
root@macbookair:~/Build/krunvm/target/release# ./krunvm delete -f asahi-krun
Error: error unmounting container asahi-krun-working-container: container not known
buildah returned an error: 
Error: removing container "asahi-krun-working-container": container not known
buildah returned an error: 
root@macbookair:~/Build/krunvm/target/release# ./krunvm delete -f asahi-krun
No VM found with that name