containers / krunvm

Create microVMs from OCI images
Apache License 2.0
1.41k stars 42 forks source link

Resolve clippy warnings and use correct types in bindings #47

Closed mtjhrc closed 10 months ago

mtjhrc commented 11 months ago

bindings were using i8 instead of c_char for C string pointers, but the types are defined as c_char in libkrun.

There were a lot of unnecessary casts from i8 to c_char according to clippy because on x86_64 they are the same type. (The casts were necessary on ARM, because c_char is unsigned on ARM).

slp commented 10 months ago

LGTM, thanks!