containers / krunvm

Create microVMs from OCI images
Apache License 2.0
1.41k stars 42 forks source link

Pass environment variable(s) to microVM #58

Closed EduM22 closed 3 months ago

EduM22 commented 7 months ago

Added the ability to pass environment variable(s) to the microVM when starting it.

slp commented 7 months ago

Thanks for your contribution. Could you please remove the third empty commit?

EduM22 commented 7 months ago

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

ericcurtin commented 7 months ago

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

EduM22 commented 7 months ago

Thanks for your contribution. Could you please remove the third empty commit?

how do I do it?, Is it easier to create a new pull request?

git rebase -i HEAD~3

is a useful tool if you want to change one of the last three commits. Or "drop" one in this case.

Although if the empty commit was at the HEAD, it's simpler to do:

git reset --hard HEAD~

and then a:

git push -f

people create new PRs sometimes to redo things, which is ok, but it's something you rarely have to do.

Thanks for the help.

@slp is it up to spec now?

h7io commented 3 months ago

Hey guys,

anything holding this up?

slp commented 3 months ago

Sorry, I lost track of this one. LGTM, merging it.