Closed pfw closed 1 year ago
Thanks for the PR! We shouldn't be bringing snp_attest.h
into the non-SEV builds. I think we right fix would be putting https://github.com/containers/libkrun/blob/d31747aa92cf83df2abaeb87e2a83311c135d003/init/init.c#L26, https://github.com/containers/libkrun/blob/d31747aa92cf83df2abaeb87e2a83311c135d003/init/init.c#L37 and https://github.com/containers/libkrun/blob/d31747aa92cf83df2abaeb87e2a83311c135d003/init/init.c#L38 between #ifdef SEV
build-time conditionals.
@pfw Do you want to update this PR with this approach?
No problems, I'll look at doing that.
@pfw Is there any update on this? Would you like me to make these changes?
Hi @tylerfanelli I’ve not had a chance to look at this but will in the next couple of days but I’m more than happy for you to take a look if you have time.
build_on_krunvm.sh was failing with an error of a missing header in the linux vm.