search

containers / libocispec

a C library for accessing OCI runtime and image spec files
Other
52 stars 30 forks source link

Move header files under ocispec/ #120

Closed ronalabraham closed 2 years ago

ronalabraham commented 2 years ago

A couple of header file names (read-file.h, json_common.h) are a bit generic. To avoid filename collisions, it would be nice to install the headers in a subdirectory (ocispec/) of the $(includedir). This would also match the pattern of yajl, which installs headers in include/yajl.

This will require some follow-up changes to crun to refer to the correct libocispec header file locations.

Signed-off-by: Ronal Abraham ronalabraham@gmail.com

ronalabraham commented 2 years ago

@flouthoc Yes, I think that would work for me. @giuseppe What do you prefer?

giuseppe commented 2 years ago

since we install these files I think it is better if we create a subdirectory.

@flouthoc if you are fine as well with the current version, please merge it :)

flouthoc commented 2 years ago

since we install these files I think it is better if we create a subdirectory.

@flouthoc if you are fine as well with the current version, please merge it :)

ah yes sounds good to me.