search

containers / netavark-dhcp-proxy-deprecated

DHCP proxy for Netavark
11 stars 7 forks source link

Handle SIGINT signals #18

Closed Jackbaude closed 2 years ago

Jackbaude commented 2 years ago

Wait for a SIGINT signal from the process and clean up UDS socket before shutdown.

Signed-off-by: Jack jackbaude@gmail.com

baude commented 2 years ago

you need to run the validator

Jackbaude commented 2 years ago

@baude All checks passed. Please let me know thoughts on line 132 as mentioned above.

flouthoc commented 2 years ago

Maybe something on the lines of ( you can remove unwrap in actual code)

tokio::signal::unix::signal(SignalKind::terminate()).unwrap().recv().await
baude commented 2 years ago

please add a test

Jackbaude commented 2 years ago

@baude ptal

baude commented 2 years ago

/approve

Jackbaude commented 2 years ago

@baude, @flouthoc, @Luap99. Is this PR ready to merge?

baude commented 2 years ago

did you resolve all the comments from folks @Jackbaude ?

flouthoc commented 2 years ago

Some non-blocking nits but overall LGTM

Jackbaude commented 2 years ago

Some non-blocking nits but overall LGTM

@flouthoc Anything I can fix?

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, flouthoc, Jackbaude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/netavark-dhcp-proxy/blob/main/OWNERS)~~ [baude,flouthoc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
baude commented 2 years ago

/lgtm