containers / nri-plugins

A collection of community maintained NRI plugins
https://containers.github.io/nri-plugins/
Apache License 2.0
68 stars 25 forks source link

e2e: skip long running tests by default. #373

Closed klihub closed 2 months ago

klihub commented 2 months ago

Skip tests matching *long*, *fuzz*, or *stress* by default. Run them when skip_long_tests=no is set.

klihub commented 2 months ago

@askervin @fmuyassarov @kad @pfl PTAL.

klihub commented 2 months ago

LGTM.

The only improvement that I could come up with is printing something like "SKIP $TEST_DIR (long_tests=no)", as I can imagine myself wondering after few months why ./run_tests.sh doesn't do anything.

Good point. I'm think I myself would not realize after a week why long tests are not run at all. Updated, adding printouts when we skip tests. I also inverted the control variable name and semantics to skip_long_tests, which feels more correct.