containers / nri-plugins

A collection of community maintained NRI plugins
https://containers.github.io/nri-plugins/
Apache License 2.0
67 stars 24 forks source link

dev: add Tiltfile for local development #382

Closed fmuyassarov closed 1 month ago

fmuyassarov commented 1 month ago

This commit adds a Tiltfile to simplify local development with Tilt.

How to use it? To run balloons policy: tilt up balloons To run topology-aware policy: tilt up topology-aware

All it does is:

  1. build the binary
  2. create a container image and push to a temporary registry
  3. deploy the policy Helm chart
askervin commented 1 month ago

I suppose this is ok, but the maintenance burden should be minimized. That is, go or docker build logic and parameterization should not be duplicated but used through make instead.

fmuyassarov commented 1 month ago

I have updated the binary build process to use the existing Makefile target. However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

klihub commented 1 month ago

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

fmuyassarov commented 1 month ago

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

Do you think current state is okay to merge?

klihub commented 1 month ago

However, we can't replace the container image build process (docker_build) with a Makefile target. The docker_build is needed for instructing Tilt on how to build the image. Without it, Tilt won't be able to trigger dependent tasks, such as deploying Kubernetes manifests into a cluster.

That should be fine, the docker builds/Dockerfiles use the build system.

Do you think current state is okay to merge?

Yes, I think it should be fine.

fmuyassarov commented 1 month ago

ping @askervin