Closed klihub closed 1 week ago
Looks great!
@klihub, would you prefer to address my nits & supernits (to the extent you find reasonable) now or later? I'm fine merging this as is.
Let me take a look at them and see how many I could address right now.
Looks great! @klihub, would you prefer to address my nits & supernits (to the extent you find reasonable) now or later? I'm fine merging this as is.
Let me take a look at them and see how many I could address right now.
@askervin I tried to address all your comments.
This patch series refactors our metrics collection code, moving most of the code to handle metrics registration, collection, and gathering into a single package in
pkg/metrics
. In particular, this seriespkg/metrics
resmgr
,resmgr/{metrics,policycollector}
policy
package itselfopencensus
topromhttp
for metrics exporting inpkg/instrumentation