search

containers / nri-plugins

A collection of community maintained NRI plugins
https://containers.github.io/nri-plugins/
Apache License 2.0
67 stars 24 forks source link

[stacked 3/5] metrics: simplify policy/backend metrics collection interface. #408

Closed klihub closed 1 week ago

klihub commented 3 weeks ago

Notes: This PR is stacked on top of #404.

Simplify the policy-backend metrics collection interface, reducing it to a single GetMetrics() call and a returned policy.Metrics interface, which simply implements the native prometheus collector interface with Describe() and Collect(). Update policy implementations accordingly.

pfl commented 3 weeks ago

Isn't this already part of commits 405 and 406?

klihub commented 3 weeks ago

Isn't this already part of commits 405 and 406?

This is like some other is this series: effectively a single commit PR, but it is stacked on top of a the previous one, in this case, PR #404.