Fix bug in getting pkcs7 certs from keys

containers / ocicrypt

Encryption libraries for Encrypted OCI Container images

Apache License 2.0

133 stars 31 forks source link

Fix bug in getting pkcs7 certs from keys #54

Closed lumjjb closed 3 years ago

lumjjb commented 3 years ago

Fixes https://github.com/containers/skopeo/issues/1320

Signed-off-by: Brandon Lum lumjjb@gmail.com

lumjjb commented 3 years ago

@pravinrajr9 this was changed from the keyprovider commit, can you verify that this fix doesn't break anything on keyprovider side?

stefanberger commented 3 years ago

Looks like this broke it? https://github.com/containers/ocicrypt/commit/cabb320230fabd790dd24c5ff66ce9bff5f6f87a#diff-6190ad5ff0b174f39a655dfa268152d635b099a47d1f30b5c1cfff95c87cb8f8L246

Fix lgtm considering the history.

lumjjb commented 3 years ago

Yea that seems to be the case.

@stefanberger can you do a github approval as well, i have enabled the protection checks to explicitly check for that now, so will need the green tick. thanks!