search

containers / ocicrypt

Encryption libraries for Encrypted OCI Container images
Apache License 2.0
133 stars 31 forks source link

Remove usage of travis and in go.mod bump go from 1.12 to 1.16 #76

Closed stefanberger closed 1 year ago

stefanberger commented 1 year ago

Remove usage of travis and in go.mod bump go from 1.12 to 1.16

BruegelN commented 1 year ago

Thanks for the follow-up @stefanberger!

One thing I want to point out that it might be worth to drop https://github.com/containers/ocicrypt/blob/f1528dcdfe21ab692886ac06710a619ea86f1b77/.github/workflows/go.yml#L5 and https://github.com/containers/ocicrypt/blob/f1528dcdfe21ab692886ac06710a619ea86f1b77/.github/workflows/go.yml#L7 such that Github Action runs on all pushes (tags and branches) and pull_request cf https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push

stefanberger commented 1 year ago

I had looked at containerd's file and imgcrypt's file and both of them have the [main] branch so I thought this was going to behave as expected running the actions on PRs trying to merge into main. I don't have any branches, so main alone seemed fine.