search

containers / ocicrypt

Encryption libraries for Encrypted OCI Container images
Apache License 2.0
146 stars 33 forks source link

gh: move files inside `.github/` dir #87

Closed SauravMaheshkar closed 1 year ago

SauravMaheshkar commented 1 year ago

This PR aims to move the SECURITY.md and CODE_OF_CONDUCT.md file from the root of the directory to the .github/ directory. Github looks for a contribution guideline file in the following order: .github dir > project root > docs dir (source). Moving the files to the .github/ dir leads to a minimal project structure without any functional change.

stefanberger commented 1 year ago

I looked around on the other projects of github.com/containers and they all have it in their root directory. Are you going to change it for these as well?

SauravMaheshkar commented 1 year ago

I looked around on the other projects of github.com/containers and they all have it in their root directory. Are you going to change it for these as well?

Yes, I'm more than happy to make PRs in other repositories within the containers namespace 😄

I'm assuming the first one should be the containers/common repository

stefanberger commented 1 year ago

I'm assuming the first one should be the containers/common repository

It's your choice. I think these files should remain visible right in the root directory.

SauravMaheshkar commented 1 year ago

I'm assuming the first one should be the containers/common repository

It's your choice. I think these files should remain visible right in the root directory.

In that case, I think I'll raise a issue in containers/common and then depending on the response follow up/close this PR.