search

containers / ocidir-rs

Low level Rust library for working with OCI (opencontainers) directories
Apache License 2.0
6 stars 3 forks source link

Add support for external blobs #22

Closed ariel-miculas closed 1 month ago

ariel-miculas commented 1 month ago

This feature is especially useful when we want to share blobs across OCI repositories. See the --dest-shared-blob-dir option in skopeo [1] as well as the LXC OCI template [2] (specifically OCI_USE_CACHE).

closes #21

[1] https://github.com/containers/skopeo/blob/main/docs/skopeo-copy.1.md [2] https://github.com/lxc/lxc/blob/main/templates/lxc-oci.in

ariel-miculas commented 1 month ago

Nice and simple, I only have minor nits.

PR title/commit message I think should be updated - this isn't about symlinks anymore.

Something like:

Add support for external blobs

?

Oh, I see, it's because you can pass whatever blobs directory you want, it doesn't have to go through a symlink. Took me a while to understand.

ariel-miculas commented 1 month ago

@cgwalters any objections to the latest changes? If not, I'll go ahead and merge this.