containers / podlet

Generate Podman Quadlet files from a Podman command, compose file, or existing object
https://crates.io/crates/podlet
Mozilla Public License 2.0
318 stars 10 forks source link

fix(compose): `network_mode` accept all podman values #42

Closed k9withabone closed 6 months ago

k9withabone commented 6 months ago

Closes #38

The error message for network_mode values of service now looks like:

Error: 
   0: Could not parse service `test` as a valid podman command
   1: network_mode `service:` is not supported by podman

Location:
   src/cli/container/quadlet.rs:807

Suggestion: try using the `container:` network_mode instead
Suggestion: see the --network section of the podman-run(1) documentation for supported values: https://docs.podman.io/en/stable/markdown/podman-run.1.html#network-mode-net
k9withabone commented 6 months ago

@trijpstra-fourlights what do you think?

trijpstra-fourlights commented 6 months ago

LGTM! :+1: nice work