containers / podlet

Generate Podman Quadlet files from a Podman command, compose file, or existing object
https://crates.io/crates/podlet
Mozilla Public License 2.0
422 stars 12 forks source link

Converting compose file fails when image registry url has a port #91

Open vaahtokarkki opened 3 months ago

vaahtokarkki commented 3 months ago

Podlet fails to parse image from compose file when the image registry url has a port defined. Reproducible with following steps;

Following error is printed:

Error:
   0: error converting compose file
   1: error reading compose file
   2: File `/compose.yaml` is not a valid compose file
   3: services.test.image: invalid image tag: image tag contains invalid character '/', tags must only contain ASCII letters (a-z, A-Z), digits (0-9), dots (.), underscores (_), and dashes (-) at line 3 column 12
nhi-vanye commented 1 month ago

Also getting hit by this.

k9withabone commented 2 weeks ago

Good catch. I didn't think about registry ports when writing the image Name validation logic as it's not included in the regex of the spec and the "Implementers Note" wasn't there.

k9withabone commented 2 weeks ago

Blocked on k9withabone/compose_spec_rs#22.