search

containers / podman-bootc

Apache License 2.0
24 stars 9 forks source link

disk: Simplify logging with attach API, use tty #37

Closed cgwalters closed 6 months ago

cgwalters commented 6 months ago

Using the Attach API is way simpler than us forwarding output manually.

Set up a terminal by default, and together this fixes things like having bootc display an interactive spinner.

ckyrouac commented 6 months ago

agh, I accidentally ran the e2e tests against main thinking I was running them against this branch. This broke the e2e tests, and the podman run flow is broken on my system. Still troubleshooting but when doing a run that involves a disk build, the ssh session connection is broken until hitting ctrl-c.

cgwalters commented 6 months ago

Hmm. Sorry for not running those tests! Let's go ahead and revert.

cgwalters commented 6 months ago

Still troubleshooting but when doing a run that involves a disk build, the ssh session connection is broken until hitting ctrl-c.

https://github.com/containers/podman-bootc/pull/41 fixes this for me