containers / podman-compose

a script to run docker-compose.yml using podman
GNU General Public License v2.0
5.01k stars 477 forks source link

Fix support for older python versions #887

Closed baszoetekouw closed 7 months ago

baszoetekouw commented 7 months ago

This PR replaces #869 It retains the changes needed to support older python versions.

Also, it makes some changes to the CI, notably:

As a side note: because coverage now is checked in the CI, it might make sense to enable a tool like https://codecov.io/, which provides a nice web interface showing where coverage is missing, and also adds an automatic CI check to check that new PRs don't decrease coverage.

p12tic commented 7 months ago

In Fix python>3.11 compatibility what was mean is probably `Fix python<3.11 compatibility.

Split out the different tests in separate CI steps ... commit message is too long, should be max 72 characters. Now it overflows.

p12tic commented 7 months ago

Overall looks good. I stand corrected, can bring back pylint.

baszoetekouw commented 7 months ago

Thanks for the feedback! This should fix the outstanding issues.

p12tic commented 7 months ago

Match editorconfig max line length with ruff config should be part of add editorconfig. Aside from that, all is good. Thanks!

baszoetekouw commented 7 months ago

done!