search

containers / podman-compose

a script to run docker-compose.yml using podman
GNU General Public License v2.0
4.86k stars 465 forks source link

FIX issue https://github.com/containers/podman-compose/issues/704 - Windows fix sock not working. #905

Closed acotty closed 3 months ago

acotty commented 3 months ago

From issue 704: Describe the bug I try to use portainer. On podman-compose up -d - /run/podman/podman.sock:/var/run/docker.sock in docker-compose.yml becomes -v E:\run\podman\podman.sock:/var/run/docker.sock:Z

.....snuip....

Expected behavior

-v \run\podman\podman.sock:/var/run/docker.sock:Z

instead of

Actual behavior

-v E:\run\podman\podman.sock:/var/run/docker.sock:Z

The issue is for portainer, but it also affects all sock on Windows due to the code not being windows aware.

muayyad-alsadi commented 3 months ago

the problem is that .sock is just a convention.

but it also affects all sock on Windows due to the code not being windows aware.

I would love the code to be OS agnostic as much as possible.

p12tic commented 3 months ago

@muayyad-alsadi I think this PR should have included a test before being merged.